linux - Bash while loop `done' syntax error unexpected token -

-

learning bash scripting in linux on virtualbox.

i'm writing script uses while loop ask text file write if decide not overwrite existing file, among other things.

here's code: 

#!/bin/bash  bool="true" counter="true" while [ "${bool}" == "true" ] ;     bool="false"     if [ "${counter}" == "true" ] ;     if [ $# -eq 1 ] ;         ff=$1     fi     else     read -p "enter .txt file write to: " ff     fi      txt=".txt"     if [[ $ff != *$txt* ]] ;     echo $ff     ff="$ff$txt"     echo $ff     fi      if [ -w $ff ] ;     var="true"     while [ "${var}" == "true" ] ;         var="false"         read -p "${ff} exists. want overwrite it? y/n: " yorn         if [ $yorn == "y" ] ;         echo "'$ff' being overwitten"         elif [ $yorn == "n" ] ;         echo "let's try again..."         bool="true"              else         echo "you entered command other y or n."         var="true"         fi     done     else     echo "'$ff' has been created"     fi      counter="false" done  echo "writing ${ff}..." echo "${ff}" > $ff echo "" >> $ff  declare -a alphabet=("a" "b" "c" "d" "e" "f" "g" "h" "i" "j" "k" "l" "m" "n" "o" "p" "q" "r" "s" "t" "u" "v" "w" "x" "y" "z") echo ${alphabet[@]} letters=${#alphabet[@]} echo "there ${letters} letters in alphabet" loops=$((letters*letters*letters)) echo "the script loops ${loops} times"  start=$(date +%s.%n) x in "${alphabet[@]}"     x=$x$x     y in "${alphabet[@]}"         y=$y$y     z in "${alphabet[@]}"             z=$z$z         xyz=$x$y$z         grep $xyz /usr/share/dict/words >> $ff     done     done done end=$(date +%s.%n) elapsed=$(echo "$end - $start" | bc -l) echo "the search took ${elapsed} seconds."  sleep 10s emacs $ff  exit 0

here's error done of while loop:

ubuntu@ubuntu-virtualbox:~/scripts$ ./script.sh abc ./script.sh: line 35: syntax error near unexpected token `done' ./script.sh: line 35: `done'

what's issue here?

you have 2 issues:

1) need space here. general suggestion, it's better use shell built-in[[ ... ]] on test [ ... ] in bash.

if [ "${counter}" == "true" ] ;                            ^

2) not closing if "fi" here.

  elif [ $yorn == "n" ] ;         echo "let's try again..."         bool=true   fi # <--- closing "fi" here

if indent code, spot these kind of errors more quickly.


Comments

Post a Comment

Popular posts from this blog

python - pip install -U PySide error -

-
does know how avoid following error when running pip install -u pyside per official website instructions here: https://pypi.python.org/pypi/pyside/#installing-pyside-on-a-mac-os-x-system note have done brew install qt successfully. you using pip version 7.0.3, version 7.1.2 available. should consider upgrading via 'pip install --upgrade pip' command. collecting pyside using cached pyside-1.2.4.tar.gz installing collected packages: pyside running setup.py install pyside complete output command /applications/anaconda/bin/python -c "import setuptools, tokenize;__file__='/private/var/folders/dy/ttgqhqqx3g9bsbsnqnxsk2z80000gq/t/pip-build-cpxemt/pyside/setup.py';exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\r\n', '\n'), __file__, 'exec'))" install --record /var/folders/dy/ttgqhqqx3g9bsbsnqnxsk2z80000gq/t/pip-0r7hri-record/install-record.txt --single-version-externally-managed --compile: ...
Read more

arrays - C++ error: a brace-enclosed initializer is not allowed here before ‘{’ token -

-
simple question: i'm trying initialize array within c++ class declaration: using namespace std; #include <string> class myclass{ public: string myarray[] = {"a","b","c"}; }; and i'm getting error: error: brace-enclosed initializer not allowed here before ‘{’ token no, without complied c++11 compiler, cannot initialize member array in declaration. have initialize array member in constructor. , don't use open array if know number of elements initialize array.
Read more

cytoscape.js - How to add nodes to Dagre layout with Cytoscape -

-
i trying add nodes dagre graph through cityscape.js. problem nodes not painted. code have: cy.add({ group: "nodes", data: { id:"n0",name:"n0",weight: 75 }, }); $.ajax(url).done(function(jsontree){ var newnodes=[]; for(var i=1;i<6;i++){ //var child = jsontree.result[i]; newnodes.push( { group: "nodes", data: { id: "n"+i, name:"n"+i}}, { group: "edges", data: { id: "e"+i, source: "n0", target: "n"+i } } ); } cy.add(newnodes); any ideas? have used loaded function reload graph not work. not know if have use specific function reload graph. thank in advance. you need add positions new nodes. cytoscape.js docs : it important note positions of newly added nodes must defined when calling cy.add(). nodes can not placed in graph without valid position — otherwise not displayed. yo...
Read more